removed colour handler fix

This commit is contained in:
alterNERDtive 2023-06-20 08:59:53 +02:00
parent bd9b2a322f
commit df79b76325
Signed by: alterNERDtive
GPG key ID: 547787A4FE6533F1
5 changed files with 3 additions and 32 deletions

View file

@ -1,6 +1,7 @@
# devel # devel
* fixed AE2 auto crafting needing NBT editing * fixed AE2 auto crafting needing NBT editing
* removed colour handler fix; install <https://github.com/radimous/FastVaultGear> instead
# 3.10.1.0 # 3.10.1.0

View file

@ -11,9 +11,9 @@ expertise reset after installing this mod.
## Fixes ## Fixes
* Removed the “Andersite” “joke”. * Removed the “Andersite” “joke”.
* Removed call to a colour handling event that is called several thousand times * ~~Removed call to a colour handling event that is called several thousand times
per second; gives a noticeable performance boost, but turns jewels and per second; gives a noticeable performance boost, but turns jewels and
unidentified items white unidentified items white~~ use <https://github.com/radimous/FastVaultGear>
* Fake players work with research again (e.g. Routers + Botany Pots, AE2 auto * Fake players work with research again (e.g. Routers + Botany Pots, AE2 auto
crafting) crafting)
* Fake players can put Vault Rocks on the Altar again * Fake players can put Vault Rocks on the Altar again

View file

@ -39,8 +39,6 @@ public class Configuration {
public static ConfigValue<Integer> JUNKMGMT_T3; public static ConfigValue<Integer> JUNKMGMT_T3;
public static ConfigValue<Integer> JUNKMGMT_T4; public static ConfigValue<Integer> JUNKMGMT_T4;
public static BooleanValue COLOURLESS;
static { static {
Builder builder = new Builder(); Builder builder = new Builder();
@ -115,12 +113,6 @@ public class Configuration {
builder = new Builder(); builder = new Builder();
// Bug fixes
builder.push("Fixes");
builder.comment("Fix performance issues when determining item colours (WARNING: will make jewels and unidentified gear go white)");
COLOURLESS = builder.define("colourPerformanceFix", true);
builder.pop();
CLIENTCONFIG = builder.build(); CLIENTCONFIG = builder.build();
} }
} }

View file

@ -1,21 +0,0 @@
package tv.alterNERD.VaultModTweaks.integration.mixin;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.Overwrite;
import iskallia.vault.event.ClientInitEvents;
import iskallia.vault.init.ModModels;
import net.minecraftforge.client.event.ColorHandlerEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import tv.alterNERD.VaultModTweaks.Configuration;
@Mixin(ClientInitEvents.class)
public class MixinClientInitEvents {
@Overwrite(remap = false)
@SubscribeEvent
public static void onColorHandlerRegister(ColorHandlerEvent.Item event) {
if (!Configuration.COLOURLESS.get()) {
ModModels.registerItemColors(event.getItemColors());
}
}
}

View file

@ -4,7 +4,6 @@
"compatibilityLevel": "JAVA_17", "compatibilityLevel": "JAVA_17",
"refmap": "mixins.the_vault_tweaks.refmap.json", "refmap": "mixins.the_vault_tweaks.refmap.json",
"mixins": [ "mixins": [
"MixinClientInitEvents",
"MixinCrystalBuddingConfig", "MixinCrystalBuddingConfig",
"MixinEnchantmentEntry", "MixinEnchantmentEntry",
"MixinExpertisesGuiConfig", "MixinExpertisesGuiConfig",