alterNERDtive/qmk_firmware
1
0
Fork 0
Code Pull requests Activity

gcc 8.10 compilation fix (#2914)

Browse source 
* Use memmove instead of memcpy

gcc 8.1 gives the following error:
lib/lufa/LUFA/Drivers/USB/Class/Common/HIDParser.c:93:5: error: 'memcpy' accessing 42 bytes at offsets 28 and 0 overlaps 14 bytes at offset 28 [-Werror=restrict]

This patch resolve this by using memmove instead

Signed-off-by: Sameeh <Sameeh Jubran>

* Remove ATTR_CONST from a void returning function

gcc 8.10 gives the following error when attempting to compile
lib/lufa/LUFA/Drivers/USB/Core/Events.h:334:5: error: 'const' attribute on function returning 'void' [-Werror=attributes]

Signed-off-by: Sameeh <Sameeh Jubran>
This commit is contained in:
sameehj 2018-05-10 06:39:46 +03:00 committed by Jack Humbert
parent 00596d55e3
commit 03516d5460
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/lufa/LUFA/Drivers/USB/Class/Common/HIDParser.c
View file

@ -90,7 +90,7 @@ uint8_t USB_ProcessHIDReport(const uint8_t* ReportData,
if (CurrStateTable == &StateTable[HID_STATETABLE_STACK_DEPTH - 1]) if (CurrStateTable == &StateTable[HID_STATETABLE_STACK_DEPTH - 1])
return HID_PARSE_HIDStackOverflow; return HID_PARSE_HIDStackOverflow;
memcpy((CurrStateTable + 1), memmove(CurrStateTable + 1,
CurrStateTable, CurrStateTable,
sizeof(HID_ReportItem_t)); sizeof(HID_ReportItem_t));

2
lib/lufa/LUFA/Drivers/USB/Core/Events.h
View file

@ -331,7 +331,7 @@
#if !defined(__DOXYGEN__) #if !defined(__DOXYGEN__)
/* Function Prototypes: */ /* Function Prototypes: */
#if defined(__INCLUDE_FROM_EVENTS_C) #if defined(__INCLUDE_FROM_EVENTS_C)
void USB_Event_Stub(void) ATTR_CONST; void USB_Event_Stub(void);
#if defined(USB_CAN_BE_BOTH) #if defined(USB_CAN_BE_BOTH)
void EVENT_USB_UIDChange(void) ATTR_WEAK ATTR_ALIAS(USB_Event_Stub); void EVENT_USB_UIDChange(void) ATTR_WEAK ATTR_ALIAS(USB_Event_Stub);