From b01dc36fbf09c3ebf8efe1bac54205ace1b1c6cc Mon Sep 17 00:00:00 2001
From: Joel Challis <git@zvecr.com>
Date: Thu, 23 Mar 2023 05:30:30 +0000
Subject: [PATCH] Tidy up duplication of MIN/MAX fallback implementations
 (#20236)

---
 platforms/arm_atsam/eeprom_samd.c  | 5 +----
 platforms/avr/drivers/i2c_master.c | 3 +--
 quantum/audio/audio.c              | 1 +
 quantum/audio/audio.h              | 5 -----
 quantum/color.c                    | 4 +---
 quantum/midi/midi.c                | 5 +----
 quantum/rgblight/rgblight.c        | 8 +-------
 quantum/velocikey.c                | 8 +-------
 8 files changed, 7 insertions(+), 32 deletions(-)

diff --git a/platforms/arm_atsam/eeprom_samd.c b/platforms/arm_atsam/eeprom_samd.c
index 1c1e031e5da..9c42041f2da 100644
--- a/platforms/arm_atsam/eeprom_samd.c
+++ b/platforms/arm_atsam/eeprom_samd.c
@@ -15,15 +15,12 @@
  */
 #include "eeprom.h"
 #include "debug.h"
+#include "util.h"
 #include "samd51j18a.h"
 #include "core_cm4.h"
 #include "component/nvmctrl.h"
 #include "eeprom_samd.h"
 
-#ifndef MAX
-#    define MAX(X, Y) ((X) > (Y) ? (X) : (Y))
-#endif
-
 #ifndef BUSY_RETRIES
 #    define BUSY_RETRIES 10000
 #endif
diff --git a/platforms/avr/drivers/i2c_master.c b/platforms/avr/drivers/i2c_master.c
index 524494c99d7..58939f3e00e 100644
--- a/platforms/avr/drivers/i2c_master.c
+++ b/platforms/avr/drivers/i2c_master.c
@@ -23,6 +23,7 @@
 #include "i2c_master.h"
 #include "timer.h"
 #include "wait.h"
+#include "util.h"
 
 #ifndef F_SCL
 #    define F_SCL 400000UL // SCL frequency
@@ -37,8 +38,6 @@
 
 #define TWBR_val (((F_CPU / F_SCL) - 16) / 2)
 
-#define MAX(X, Y) ((X) > (Y) ? (X) : (Y))
-
 void i2c_init(void) {
     TWSR = 0; /* no prescaler */
     TWBR = (uint8_t)TWBR_val;
diff --git a/quantum/audio/audio.c b/quantum/audio/audio.c
index 3f6dc20232d..2570ad9cd1e 100644
--- a/quantum/audio/audio.c
+++ b/quantum/audio/audio.c
@@ -18,6 +18,7 @@
 #include "eeconfig.h"
 #include "timer.h"
 #include "wait.h"
+#include "util.h"
 
 /* audio system:
  *
diff --git a/quantum/audio/audio.h b/quantum/audio/audio.h
index 6feecb5e657..497f3dafd01 100644
--- a/quantum/audio/audio.h
+++ b/quantum/audio/audio.h
@@ -43,11 +43,6 @@ typedef union {
     };
 } audio_config_t;
 
-// AVR/LUFA has a MIN, arm/chibios does not
-#ifndef MIN
-#    define MIN(a, b) (((a) < (b)) ? (a) : (b))
-#endif
-
 /*
  * a 'musical note' is represented by pitch and duration; a 'musical tone' adds intensity and timbre
  * https://en.wikipedia.org/wiki/Musical_tone
diff --git a/quantum/color.c b/quantum/color.c
index c80078dbf21..767155c9db9 100644
--- a/quantum/color.c
+++ b/quantum/color.c
@@ -17,6 +17,7 @@
 #include "color.h"
 #include "led_tables.h"
 #include "progmem.h"
+#include "util.h"
 
 RGB hsv_to_rgb_impl(HSV hsv, bool use_cie) {
     RGB      rgb;
@@ -109,9 +110,6 @@ RGB hsv_to_rgb_nocie(HSV hsv) {
 }
 
 #ifdef RGBW
-#    ifndef MIN
-#        define MIN(a, b) ((a) < (b) ? (a) : (b))
-#    endif
 void convert_rgb_to_rgbw(LED_TYPE *led) {
     // Determine lowest value in all three colors, put that into
     // the white channel and then shift all colors by that amount
diff --git a/quantum/midi/midi.c b/quantum/midi/midi.c
index 1ba3e73a402..1c481f2f0b3 100644
--- a/quantum/midi/midi.c
+++ b/quantum/midi/midi.c
@@ -18,10 +18,7 @@
 
 #include "midi.h"
 #include <string.h> //for memcpy
-
-#ifndef MIN
-#    define MIN(x, y) (((x) < (y)) ? (x) : (y))
-#endif
+#include "util.h"
 
 #ifndef NULL
 #    define NULL 0
diff --git a/quantum/rgblight/rgblight.c b/quantum/rgblight/rgblight.c
index 4c476f924f9..02188df95b8 100644
--- a/quantum/rgblight/rgblight.c
+++ b/quantum/rgblight/rgblight.c
@@ -21,6 +21,7 @@
 #include "rgblight.h"
 #include "color.h"
 #include "debug.h"
+#include "util.h"
 #include "led_tables.h"
 #include <lib/lib8tion/lib8tion.h>
 #ifdef EEPROM_ENABLE
@@ -30,13 +31,6 @@
 #    include "velocikey.h"
 #endif
 
-#ifndef MIN
-#    define MIN(a, b) (((a) < (b)) ? (a) : (b))
-#endif
-#ifndef MAX
-#    define MAX(a, b) (((a) > (b)) ? (a) : (b))
-#endif
-
 #ifdef RGBLIGHT_SPLIT
 /* for split keyboard */
 #    define RGBLIGHT_SPLIT_SET_CHANGE_MODE rgblight_status.change_flags |= RGBLIGHT_STATUS_CHANGE_MODE
diff --git a/quantum/velocikey.c b/quantum/velocikey.c
index 58e14215bb3..03e91911f6c 100644
--- a/quantum/velocikey.c
+++ b/quantum/velocikey.c
@@ -2,13 +2,7 @@
 #include "timer.h"
 #include "eeconfig.h"
 #include "eeprom.h"
-
-#ifndef MIN
-#    define MIN(a, b) (((a) < (b)) ? (a) : (b))
-#endif
-#ifndef MAX
-#    define MAX(a, b) (((a) > (b)) ? (a) : (b))
-#endif
+#include "util.h"
 
 #define TYPING_SPEED_MAX_VALUE 200
 uint8_t typing_speed = 0;