EliteDangerous/VoiceAttack-profiles
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases 33 Wiki Activity Actions

Proof reading and minor issues correction #137

Closed
ACyprus wants to merge 0 commits from gh-pages into gh-pages
pull from: gh-pages
merge into: EliteDangerous:gh-pages
Conversation 3 Commits - Files changed 91 +2567 -2262
ACyprus commented 2022-05-20 17:12:39 +02:00 (Migrated from github.com)
Copy link

In this pull request, I have:

  • corrected minor issues, typos, duplications and broken links
  • not addressed general grammar, use of commas etc
  • included each change via a separate commit to make cherry picking easier
  • noted any assumptions made when unsure in the commit description
In this pull request, I have: - corrected minor issues, typos, duplications and broken links - not addressed general grammar, use of commas etc - included each change via a separate commit to make cherry picking easier - noted any assumptions made when unsure in the commit description
alterNERDtive (Migrated from github.com) reviewed 2022-05-20 17:23:19 +02:00
general/index.html
@ -139,3 +160,3 @@
<h2 id="configuration">Configuration<a class="headerlink" href="#configuration" title="Permanent link">&para;</a></h2>
<p>The base profile provides voice commands for changing the profiles’ settings.
<p>The base profile provides voice commands for changing the profile’s settings.
See <a href="../configuration/general#settings">the configuration section</a>.</p>
alterNERDtive (Migrated from github.com) commented 2022-05-20 17:23:19 +02:00
Copy link

This was actually correct/intended; if you want to change it, then to profiles’.

This was actually correct/intended; if you want to change it, then to `profiles’`.
alterNERDtive (Migrated from github.com) reviewed 2022-05-20 17:25:00 +02:00
requirements/index.html
@ -160,3 +181,3 @@
as a VoiceAttack plugin.</p>
<p>EDDI also regularly publishes beta versions. Unless a profiles release
<p>EDDI also regularly publishes beta versions. Unless a profile’s release
explicitly states it you will <em>not</em> have to run EDDI beta.</p>
alterNERDtive (Migrated from github.com) commented 2022-05-20 17:25:00 +02:00
Copy link

Same here, that’s intended :)

Same here, that’s intended :)
alterNERDtive commented 2022-05-20 17:26:12 +02:00 (Migrated from github.com)
Copy link

As I already told you in Discord, sadly you’ll have to redo this on the markdown files in docs/ from which the Github Pages are generated :-/

As I already told you in Discord, sadly you’ll have to redo this on the markdown files in `docs/` from which the Github Pages are generated :-/
👍 1
ACyprus (Migrated from github.com) reviewed 2022-05-20 17:26:50 +02:00
requirements/index.html
@ -160,3 +181,3 @@
as a VoiceAttack plugin.</p>
<p>EDDI also regularly publishes beta versions. Unless a profiles release
<p>EDDI also regularly publishes beta versions. Unless a profile’s release
explicitly states it you will <em>not</em> have to run EDDI beta.</p>
ACyprus (Migrated from github.com) commented 2022-05-20 17:26:50 +02:00
Copy link

this one had no apostrophe though, and it implies ownership.

this one had no apostrophe though, and it implies ownership.
ACyprus (Migrated from github.com) reviewed 2022-05-20 17:27:20 +02:00
general/index.html
@ -139,3 +160,3 @@
<h2 id="configuration">Configuration<a class="headerlink" href="#configuration" title="Permanent link">&para;</a></h2>
<p>The base profile provides voice commands for changing the profiles’ settings.
<p>The base profile provides voice commands for changing the profile’s settings.
See <a href="../configuration/general#settings">the configuration section</a>.</p>
ACyprus (Migrated from github.com) commented 2022-05-20 17:27:20 +02:00
Copy link

Cool, the main change was due to the dodgy ’ character

Cool, the main change was due to the dodgy ’ character
alterNERDtive (Migrated from github.com) reviewed 2022-05-20 17:27:55 +02:00
requirements/index.html
@ -160,3 +181,3 @@
as a VoiceAttack plugin.</p>
<p>EDDI also regularly publishes beta versions. Unless a profiles release
<p>EDDI also regularly publishes beta versions. Unless a profile’s release
explicitly states it you will <em>not</em> have to run EDDI beta.</p>
alterNERDtive (Migrated from github.com) commented 2022-05-20 17:27:55 +02:00
Copy link

No, it’s a profiles release. Like, uh, a bombs release or something. It’s just plural.

No, it’s a profiles release. Like, uh, a bombs release or something. It’s just plural.
alterNERDtive (Migrated from github.com) reviewed 2022-05-20 17:28:32 +02:00
general/index.html
@ -139,3 +160,3 @@
<h2 id="configuration">Configuration<a class="headerlink" href="#configuration" title="Permanent link">&para;</a></h2>
<p>The base profile provides voice commands for changing the profiles’ settings.
<p>The base profile provides voice commands for changing the profile’s settings.
See <a href="../configuration/general#settings">the configuration section</a>.</p>
alterNERDtive (Migrated from github.com) commented 2022-05-20 17:28:32 +02:00
Copy link

That’s not dodgy, that’s a proper apostrophe! You heathen.

Wait I think I’m confused. What character?

~~That’s not dodgy, that’s a proper apostrophe! You heathen.~~ Wait I think I’m confused. What character?
ACyprus (Migrated from github.com) reviewed 2022-05-20 17:32:01 +02:00
general/index.html
@ -139,3 +160,3 @@
<h2 id="configuration">Configuration<a class="headerlink" href="#configuration" title="Permanent link">&para;</a></h2>
<p>The base profile provides voice commands for changing the profiles’ settings.
<p>The base profile provides voice commands for changing the profile’s settings.
See <a href="../configuration/general#settings">the configuration section</a>.</p>
ACyprus (Migrated from github.com) commented 2022-05-20 17:32:01 +02:00
Copy link

this one...

image

image

this one... ![image](https://user-images.githubusercontent.com/9026246/169561933-afcd4ac4-be0c-4b2b-b2c5-4afbec4abde0.png) ![image](https://user-images.githubusercontent.com/9026246/169562113-c218268f-7628-4d4f-8d7b-e27b519975bc.png)
ACyprus (Migrated from github.com) reviewed 2022-05-20 17:33:13 +02:00
general/index.html
@ -139,3 +160,3 @@
<h2 id="configuration">Configuration<a class="headerlink" href="#configuration" title="Permanent link">&para;</a></h2>
<p>The base profile provides voice commands for changing the profiles’ settings.
<p>The base profile provides voice commands for changing the profile’s settings.
See <a href="../configuration/general#settings">the configuration section</a>.</p>
ACyprus (Migrated from github.com) commented 2022-05-20 17:33:13 +02:00
Copy link

But yeah, conclusion is it should be plural possessive profiles'.

We loveses our profileses, silly hobbitses....

But yeah, conclusion is it should be plural possessive `profiles'`. We loveses our profileses, silly hobbitses....
alterNERDtive (Migrated from github.com) reviewed 2022-05-20 17:37:12 +02:00
general/index.html
@ -139,3 +160,3 @@
<h2 id="configuration">Configuration<a class="headerlink" href="#configuration" title="Permanent link">&para;</a></h2>
<p>The base profile provides voice commands for changing the profiles’ settings.
<p>The base profile provides voice commands for changing the profile’s settings.
See <a href="../configuration/general#settings">the configuration section</a>.</p>
alterNERDtive (Migrated from github.com) commented 2022-05-20 17:37:11 +02:00
Copy link

this one...

Funny, doesn’t even show up on Github. Yeah, IDK what that is.

> this one... Funny, doesn’t even show up on Github. Yeah, IDK what that is.
alterNERDtive commented 2022-07-08 17:54:36 +02:00 (Migrated from github.com)
Copy link

So, you still wanna send a PR against the Markdown files? Otherwise I guess I’ll have to fix all these typos myself :)

So, you still wanna send a PR against the Markdown files? Otherwise I guess I’ll have to fix all these typos myself :)
ACyprus commented 2022-07-08 18:01:37 +02:00 (Migrated from github.com)
Copy link

Ah yeah, forgot about this. I'll redo em this weekend

Ah yeah, forgot about this. I'll redo em this weekend

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
EDDI

   
EliteAttack

   
RatAttack

   
SealAttack

   
SpanshAttack

   
StreamAttack

   
awaiting feedback

   
base

   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
done

implemented, but not merged into release yet

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
invalid

This doesn't seem right

  
wontfix

This will not be worked on

No labels
EDDI
EliteAttack
RatAttack
SealAttack
SpanshAttack
StreamAttack
awaiting feedback
base
bug
dependencies
documentation
done
duplicate
enhancement
invalid
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: EliteDangerous/VoiceAttack-profiles#137
No description provided.
Delete branch "gh-pages"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?