Implement 'traffic' endpoint #5

Merged

enderlein merged 6 commits from traffic2 into develop 2022-03-12 04:07:11 +01:00

Conversation 9 Commits 6 Files changed 3 +158 -1

enderlein commented 2022-02-27 05:01:51 +01:00 (Migrated from github.com)

Copy link

No description provided.

alterNERDtive commented 2022-02-27 11:44:44 +01:00 (Migrated from github.com)

Copy link

Hey! Thanks for the PR and I’m not generally opposed to merging, but please write some basic tests :)

I am aware that you cannot really test for specific data, but please have some that ensure you receive the format you expect.

Hey! Thanks for the PR and I’m not generally opposed to merging, but please write some basic tests :) I am aware that you cannot really test for specific data, but please have some that ensure you receive the format you expect.

👍 1

alterNERDtive commented 2022-03-03 12:25:06 +01:00 (Migrated from github.com)

Copy link

Thanks, I will have a look tomorrow!

Thanks, I will have a look tomorrow!

alterNERDtive (Migrated from github.com) reviewed 2022-03-11 12:35:37 +01:00

edsm/systemApi.py

alterNERDtive (Migrated from github.com) commented 2022-03-11 12:35:37 +01:00

Copy link

This might sound nitpicky, but this is missing a newline at the end :)

This might sound nitpicky, but this is missing a newline at the end :)

alterNERDtive commented 2022-03-11 12:36:13 +01:00 (Migrated from github.com)

Copy link

Sorry, forgot about this. Looks good apart from ↑ which should only be a minute of your time.

Sorry, forgot about this. Looks good apart from ↑ which should only be a minute of your time.

alterNERDtive commented 2022-03-11 12:36:30 +01:00 (Migrated from github.com)

Copy link

(I should add an editorconfig file.)

(I should add an editorconfig file.)

enderlein commented 2022-03-11 23:59:58 +01:00 (Migrated from github.com)

Copy link

You do have an editorconfig file, I just never installed the plugin. Oops.

You do have an editorconfig file, I just never installed the plugin. Oops.

alterNERDtive commented 2022-03-12 04:06:51 +01:00 (Migrated from github.com)

Copy link

😬

😬

alterNERDtive commented 2022-03-12 04:07:41 +01:00 (Migrated from github.com)

Copy link

Want me to make a release for this? It’s not like I’m working on much else in here.

Want me to make a release for this? It’s not like I’m working on much else in here.

enderlein commented 2022-03-12 21:18:42 +01:00 (Migrated from github.com)

Copy link

Sure!

Sure!

alterNERDtive commented 2022-07-02 15:58:22 +02:00 (Migrated from github.com)

Copy link

Sorry, took me a while because … well, I forgot about it.

https://github.com/alterNERDtive/pyEDSM/releases/tag/releases%2F0.2

Sorry, took me a while because … well, I forgot about it. https://github.com/alterNERDtive/pyEDSM/releases/tag/releases%2F0.2

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something isn't working

  

dependencies

Pull requests that update a dependency file

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

github_actions

Pull requests that update GitHub Actions code

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

bug

dependencies

documentation

duplicate

enhancement

github_actions

good first issue

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: EliteDangerous/pyEDSM#5

No description provided.